RFR: JDK-8074859 Turn on warnings as error

[Magnus Ihse Bursie]

On 2015-05-20 11:50, Volker Simonis wrote:
> Hi,
>
> I'm a little confused about this change. I finally found some time to
> look at it, because it makes most of our nightly jdk9/dev builds fail.
> Now I've looked at the 'simplest possible failure' which happens on
> linux/amd64. The failure is the following:
>
> /net/usr.work/openjdk/nb/linuxx86_64/nightly/jdk9/jdk/src/java.base/share/native/libjava/jdk_util.c:79:5:
> error: comparison of unsigned expression >= 0 is always true
> [-Werror=type-limits]
>
> First I thought this is because we are using a different version of
> GCC but I've just verified that this warning which is now turned into
> an error happens with all version of GCC starting from at least 4.3 up
> to 4.8.
>
> So do you do your regular builds on linux/amd64 by default with
> "--disable-warnings-as-errors" now?
>
> Reading you first mail, the code should compile fine on the build
> systems used internally at Oracle and according to
> https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms
> they should use gcc 4.8.2.
>
> So what's the problem here or am I doing something wrong?

As David says, this warning should have been disabled. Can you paste the 
entire command line for the gcc compilation of jdk_util.c? It should 
contain a -Wno-type-limits.

/Magnus