RFR(XS): 8168137 - import-hotspot build target not removed from hotspot-ide-project

[Erik Joelsson]

Looks good.


On 2016-12-20 04:15, David Holmes wrote:
> Hi Christian,
>
> On 20/12/2016 8:43 AM, Christian Tornqvist wrote:
>> Hi,
>>
>>
>>
>> Please review this small change to not use the import-hotspot make 
>> target,
>> also updated where to find jvm.dll once the build has completed.
>>
>> Tested using make hotspot-ide-project and then using VS to
>> build/rebuild/debug using the generated project files.
>>
>>
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~ctornqvi/webrev/8168137/webrev.00/
>
> make/src/classes/build/tools/projectcreator/WinGammaPlatformVC10.java
>
> Looks fine.
>
> make/ide/CreateVSProject.gmk
>
> Not sure why the output path has been changed ?? Seems unrelated to 
> the import-hotspot issue.
>
In an attempt to reduce output dir size, I moved the output dir for 
linking to the standard location for all jdk native libraries:

$(SUPPORT_OUTPUTDIR)/modules_libs/java.base/server

This is also automatically copied to

$(JDK_OUTPUTDIR)/lib/server

for the exploded image. Both locations are populated when doing "make 
hotspot" and I recommended Christian to use the latter since there, 
libjvm.so is positioned in a context where it can actually run.

/Erik

> Thanks,
> David
>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8168137
>>
>>
>>
>> Thanks,
>>
>> Christian
>>
>>
>>