RFR: JDK-8063154: Checked in jvmti.h not in sync with generated jvmti.h
serguei.spitsyn at oracle.com
serguei.spitsyn at oracle.com
Wed Nov 2 13:27:30 UTC 2016
Hi Erik
+1 to what Tim said.
Thank you a lot for fixing this issue!
Thanks,
Serguei
On 11/1/16 14:38, Tim Bell wrote:
> Erik:
>
>> New webrev: http://cr.openjdk.java.net/~erikj/8063154/webrev.02/
>>
>> I had not managed to revert all changes from another patch.
>>
>> /Erik
>>
>>
>> On 2016-11-01 17:22, Erik Joelsson wrote:
>>> Hello,
>>>
>>> The header file jvmti.h is generated in the hotspot build. There is
>>> also a copy of this file in the jdk repository which is the one that
>>> is actually included in the jdk image. This patch removes the copy and
>>> uses the generated file instead. JDK-8147943 fixed the generated file
>>> so that it has the correct license header, making the files equivalent
>>> at this time, so this change is not changing the build output.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8063154
>>>
>>> Webrev: http://cr.openjdk.java.net/~erikj/8063154/webrev.01/
>
> Looks good. Approved. It is nice to get down to one copy of jvmti.h.
>
> Tim
>
>
More information about the build-dev
mailing list