RFR: JDK-8063154: Checked in jvmti.h not in sync with generated jvmti.h

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Nov 7 12:43:38 UTC 2016


Hi,

On 2016-11-01 17:56, Erik Joelsson wrote:
> New webrev: http://cr.openjdk.java.net/~erikj/8063154/webrev.02/
>
> I had not managed to revert all changes from another patch.

Looks good to me, but please remove this comment as well:

  # Disable copy of jvmti.h from hotspot until this has been cleared up. 
The file
  # is currently being copied from the jdk repository. See JDK-8167078.

/Magnus
>
> /Erik
>
>
> On 2016-11-01 17:22, Erik Joelsson wrote:
>> Hello,
>>
>> The header file jvmti.h is generated in the hotspot build. There is 
>> also a copy of this file in the jdk repository which is the one that 
>> is actually included in the jdk image. This patch removes the copy 
>> and uses the generated file instead. JDK-8147943 fixed the generated 
>> file so that it has the correct license header, making the files 
>> equivalent at this time, so this change is not changing the build 
>> output.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8063154
>>
>> Webrev: http://cr.openjdk.java.net/~erikj/8063154/webrev.01/
>>
>> /Erik
>>
>




More information about the build-dev mailing list