RFR 8173715: Remove Flat Profiler

[David Holmes]

On 22/08/2017 11:36 PM, Gerard Ziemski wrote:
> Thank you for the review.
> 
> 
>> On Aug 21, 2017, at 8:01 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>>
>> Build changes look good.
>>
>> Don't forget to regenerate configure and push both the closed and open generated-configure script with this change.
> 
> I’m not 100% sure which files we’re talking about, can you point out the files you just referred to please?

When you change a .m4 file you have to regenerate the 
generated-configure.sh scripts. With a full forest (open and closed) you 
would do:

#> (cd common/autoconf/ && sh autogen.sh)

which will generate open and closed generated-configure.sh files, which 
will have to committed and pushed with the change. You'll need to do 
this on a linux system (most likely) with autoconf 2.69 available.

David
-----

> 
> 
>>
>> /Erik
>>
>>
>> On 2017-08-18 23:09, Gerard Ziemski wrote:
>>> hi all,
>>>
>>> The FlatProfiler (i.e. -Xprof) has been deprecated in jdk9, and now it’s the time to remove the code and obsolete the -Xprof flag.
>>>
>>> issue:           https://bugs.openjdk.java.net/browse/JDK-8173715
>>> jdk repo webrev: http://cr.openjdk.java.net/~gziemski/8173715_rev2_repo/
>>> hotspot webrev:  http://cr.openjdk.java.net/~gziemski/8173715_rev2_hotspot/
>>>
>>> Specific files to review:
>>>
>>> http://cr.openjdk.java.net/~gziemski/8173715_rev2_repo/common/autoconf/hotspot.m4.udiff.html
>>> http://cr.openjdk.java.net/~gziemski/8173715_rev2_hotspot/make/lib/JvmFeatures.gmk.udiff.html
>>>
>>
>