RFR 8173715: Remove Flat Profiler
Gerard Ziemski
gerard.ziemski at oracle.com
Wed Aug 23 16:40:06 UTC 2017
> On Aug 22, 2017, at 9:10 PM, David Holmes <david.holmes at oracle.com> wrote:
>
> On 22/08/2017 11:36 PM, Gerard Ziemski wrote:
>> Thank you for the review.
>>> On Aug 21, 2017, at 8:01 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>>>
>>> Build changes look good.
>>>
>>> Don't forget to regenerate configure and push both the closed and open generated-configure script with this change.
>> I’m not 100% sure which files we’re talking about, can you point out the files you just referred to please?
>
> When you change a .m4 file you have to regenerate the generated-configure.sh scripts. With a full forest (open and closed) you would do:
>
> #> (cd common/autoconf/ && sh autogen.sh)
>
> which will generate open and closed generated-configure.sh files, which will have to committed and pushed with the change. You'll need to do this on a linux system (most likely) with autoconf 2.69 available.
Thank you for the explanation - I did this on my Mac.
cheers
More information about the build-dev
mailing list