RFC: nashorn sources are missing in src.zip

Erik Joelsson erik.joelsson at oracle.com
Tue Jan 3 08:03:28 UTC 2017


Hello Jiri,

Please see related issue [1] which was included early in JDK 9 but the 
backport was never done. I don't personally mind including more sources 
in src.zip for OpenJDK, but instead of adding them piecemeal I would 
argue for reopening the backport. I don't know if such a change is 
suitable for 8u at this point though. The size of src.zip increases 
quite dramatically. However, it should be noted that it's only included 
in the JDK image and not the JRE.

For anyone unsure of the role of src.zip, it's only use is for IDEs to 
see the JDK sources to aid debugging of other applications.

/Erik

[1] https://bugs.openjdk.java.net/browse/JDK-8044235

On 2017-01-02 17:41, Jiri Vanek wrote:
> https://jvanek.fedorapeople.org/oracle/jdk8/webrevs/nashornMissingInSrcZip/v1/webrev/ 
>
>
> Hello good people!
>
> I have found, that nashorn sources are missing in src.zip.
> It is easily fixable by webrev above.
>
> If you will think about it as "private api",  jdk9 *have* nashorn 
> module sources included.
>
> Actually more sun* sources are missing. Or even more sources which 
> result to ext directory. Imho they should be included too. I will 
> prepare patches for each set separately, if it will be agreed.
>
> I know that sun* are somehow deprecated. But it is sad when you can 
> not easily debug inside the JDK. The absence of theirs in src.zip is 
> not the cure.
>
> Thanx!
>   J.




More information about the build-dev mailing list