RFR: JDK-8171929: "make docs" in clean forest is broken

Tim Bell tim.bell at oracle.com
Tue Jan 3 19:31:13 UTC 2017


Erik:

On 01/03/17 11:27, Mandy Chung wrote:
>
>> On Dec 27, 2016, at 2:40 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>>
>> The new module, jdk.vm.compiler (as well as jdk.vm.ci), requires access to some of the newly built class files in order to run an annotation processor in the gensrc step. The extra dependency declaration for this is currently missing one module (java.instrument) in make/Main.gmk. To avoid having to maintain the list of modules they depend on in two places (module-info.java and the makefile), we can generate the dependency targets in the makefile, since we already have the module dependency information in make.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8171929
>>
>> Webrev: http://cr.openjdk.java.net/~erikj/8171929/webrev.01/
>
> This looks okay to me.
>
> Mandy

Looks good to me as well.

/Tim




More information about the build-dev mailing list