[PATCH] Request for Review: Override TESTDIRS correctly in tests
Siddhesh Poyarekar
siddhesh at gotplt.org
Fri Jan 4 11:11:41 UTC 2019
Hello,
The TESTDIRS override method of selecting a subset of tests currently
does not work because the TEST_SELECTION variable is not overridden
correctly; it needs the 'override' keyword to override its value.
Attached patch fixes this.
Siddhesh
PS: My contributions should be covered under my employer's (Linaro)
copyright assignment.
-------------- next part --------------
diff -r 2c8e6decb1c3 test/TestCommon.gmk
--- a/test/TestCommon.gmk Mon Dec 03 14:25:00 2018 +0100
+++ b/test/TestCommon.gmk Fri Jan 04 11:00:21 2019 +0000
@@ -322,7 +322,7 @@
# The TESTDIRS variable can be used to select the jtreg tests to run
ifdef TESTDIRS
- TEST_SELECTION = $(TESTDIRS)
+ override TEST_SELECTION = $(TESTDIRS)
endif
ifeq ($(UNAME_S), SunOS)
More information about the build-dev
mailing list