[PATCH] Request for Review: Override TESTDIRS correctly in tests

[Erik Joelsson]

Hello Siddhesh,

I'm curious about what you are trying to do to end up needing this 
override. The old test makefiles have a very confusing UI and my guess 
is that you are using input variables (TESTDIRS) with a target they 
aren't meant for.

Instead of trying to fix this, I would strongly recommend moving away 
from using the makefiles in test/ as those are deprecated and will be 
removed eventually. We have a new makefile framework for running tests. 
See doc/testing.md for details on how to use it. From a user perspective 
it's far easier to use and much more powerful, as well as reasonably 
well documented.

/Erik

On 2019-01-04 12:11, Siddhesh Poyarekar wrote:
> Hello,
>
> The TESTDIRS override method of selecting a subset of tests currently 
> does not work because the TEST_SELECTION variable is not overridden 
> correctly; it needs the 'override' keyword to override its value. 
> Attached patch fixes this.
>
> Siddhesh
>
> PS: My contributions should be covered under my employer's (Linaro)
> copyright assignment.