RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v2]

Thu Dec 3 23:27:56 UTC 2020

On Thu, 3 Dec 2020 22:59:23 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> @JornVernee Thanks for your feedback! I'll have a closer look at your examples, and see if I can reproduce them in my own environment. One question, your first example, was this from a Cygwin environment?
>> 
>> As a general comment, the idea is that paths to configure options should be in "unix" style. If that is not accepted, it is a bug. (Otoh, I try hard to be tolerant and accept Windows style or mixed-style ("c:/windows") paths as well, but this is not guaranteed to work.)
>
> @magicus Ah dang, I tested passing `--with-tools-dir` a unix path before but messed up the drive letter. So, passing unix path to `--with-tools-dir` (i.e. `--with-tools-dir='/cygdrive/j/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools'`) works after all (though IIRC this wasn't the case in the past).

@JornVernee Yes, this can certainly have been wrong in the past. That's one of the things that I've fixed with this patch, making sure we handle paths correctly :-)

Does this mean the patch works for you on both Cygwin and WSL now?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1597