RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v2]

[Jorn Vernee]

On Thu, 3 Dec 2020 23:25:28 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> @magicus Ah dang, I tested passing `--with-tools-dir` a unix path before but messed up the drive letter. So, passing unix path to `--with-tools-dir` (i.e. `--with-tools-dir='/cygdrive/j/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools'`) works after all (though IIRC this wasn't the case in the past).
>
> @JornVernee Yes, this can certainly have been wrong in the past. That's one of the things that I've fixed with this patch, making sure we handle paths correctly :-)
> 
> Does this mean the patch works for you on both Cygwin and WSL now?

@magicus No, the same problems still remain. I seem to have narrowed down the first error to the `set-vs-env.sh` script.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1597