RFR: 8257679: Improved unix compatibility layer in Windows build (winenv) [v2]

[Jorn Vernee]

On Thu, 3 Dec 2020 23: 31:34 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> @JornVernee Yes, this can certainly have been wrong in the past. That's one of the things that I've fixed with this patch, making sure we handle paths correctly :-)
>> 
>> Does this mean the patch works for you on both Cygwin and WSL now?
>
> @magicus No, the same problems still remain. I seem to have narrowed down the first error to the `set-vs-env.sh` script; the PATH it extracts for VS_PATH contains `usr\local\bin` for some reason.
> 
> <values that seem to come from vcvars>
> C:\windows\system32
> H:\cygwin64\bin
> usr\local\bin
> H:\cygwin64\usr\local\bin
> H:\cygwin64\bin
> <contents of system PATH>

Ok, it seems to have been caused by `usr/local/bin` being added to my Cygwin PATH in .bash_profile. If I remove that I get a little further.

But the same command fails later on a path with a space in it:

fixpath: failure: Path '/cygdrive/c/progra~2/ati technologies/ati.ace/core-static' contains space

Looks like a missing short/8dot3 path for one directory. I'll try to get it working on my end. I'll take further questions offline to keep this thread focused on the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1597