RFR: 8257450: Start of release updates for JDK 17 [v2]

[Jonathan Gibbons]

On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8257450
>  - Update tests.
>  - Merge branch 'master' into JDK-8257450
>  - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
>  - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
>  - JDK-8257450
>  - JDK-8257450
>  - JDK-8257450

I've read all the files, and approve all the langtools related ones (i.e. not hotspot)
As you've noticed elsewhere, there's a pending conflict with Magnus' work to move files around.

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 108:

> 106: 
> 107:     /**
> 108:       * 16, tbd

The "tbd" can presumably be filled in now

test/jdk/java/lang/module/ClassFileVersionsTest.java line 107:

> 105:                 { 61,   0,  Set.of(STATIC, TRANSITIVE) },
> 106: 
> 107:                 { 62,   0,  Set.of()},                       // JDK 18

This seems unduly repetitive. Could this be dynamically generated, perhaps in a future release?

test/langtools/tools/javac/preview/classReaderTest/Client.preview.out line 1:

> 1: - compiler.warn.preview.feature.use.classfile: Bar.class, 17

Is this a test can could be automated? (i.e. no manual change per release?)

test/langtools/tools/javac/versions/Versions.java line 26:

> 24: /*
> 25:  * @test
> 26:  * @bug 4981566 5028634 5094412 6304984 7025786 7025789 8001112 8028545 8000961 8030610 8028546 8188870 8173382 8173382 8193290 8205619 8028563 8245147 8245586 8257453

long lines are annoying

test/langtools/tools/javac/versions/Versions.java line 297:

> 295:        expectedPass(args, List.of("New7.java", "New8.java", "New10.java", "New11.java",
> 296:                                   "New14.java", "New15.java"));
> 297:         expectedFail(args, List.of("New16.java"));

(minor) looks like bad indentation

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1531