RFR: 8257450: Start of release updates for JDK 17 [v2]
Joe Darcy
darcy at openjdk.java.net
Mon Dec 7 21:20:14 UTC 2020
On Mon, 7 Dec 2020 20:08:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8257450
>> - Update tests.
>> - Merge branch 'master' into JDK-8257450
>> - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
>> - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
>> - JDK-8257450
>> - JDK-8257450
>> - JDK-8257450
>
> test/jdk/java/lang/module/ClassFileVersionsTest.java line 107:
>
>> 105: { 61, 0, Set.of(STATIC, TRANSITIVE) },
>> 106:
>> 107: { 62, 0, Set.of()}, // JDK 18
>
> This seems unduly repetitive. Could this be dynamically generated, perhaps in a future release?
I've had similar thoughts; that strikes me as a fine RFE for after this fork. I see what the code is doing, but haven't delved into the module system details to understand exactly the rationale for these tests. In any case, filed the RFE JDK-8257856: "Make ClassFileVersionsTest.java robust to JDK version updates."
-------------
PR: https://git.openjdk.java.net/jdk/pull/1531
More information about the build-dev
mailing list