RFR: 8258411: Move module set configuration from Modules.gmk to conf dir [v2]

Alan Bateman alanb at openjdk.java.net
Tue Dec 15 19:30:57 UTC 2020


On Tue, 15 Dec 2020 18:15:28 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The hard-coded list of modules in `make/common/Modules.gmk` has always been a wart in the build system. We pride ourself on using discovery instead of hard-coded list. In this case, it is not possible to do do auto-discovery, since the different module sets are configured, not determined.
>> 
>> Thus the actual lists of module sets should move to the `make/conf` directory.
>> 
>> This is the first patch in a series where I will move configuration values spread over the build system into the designated `make/conf` directory.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Split up module-sets.conf

This looks better but I think we need to find better names for the conf files. Prefixing them with "module-sets" looks really strange.
JRE_TOOL_MODULES in module-sets-classloaders.conf might also need to be re-examined because it is not used to generate ModuleLoaderMap. Instead it was defined in Modules.gmk for the legacy-jre-image build target.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1781



More information about the build-dev mailing list