RFR: 8258411: Move module set configuration from Modules.gmk to conf dir [v2]
Magnus Ihse Bursie
ihse at openjdk.java.net
Tue Dec 15 20:29:55 UTC 2020
On Tue, 15 Dec 2020 19:28:33 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Split up module-sets.conf
>
> This looks better but I think we need to find better names for the conf files. Prefixing them with "module-sets" looks really strange.
> JRE_TOOL_MODULES in module-sets-classloaders.conf might also need to be re-examined because it is not used to generate ModuleLoaderMap. Instead it was defined in Modules.gmk for the legacy-jre-image build target.
I thought it was a consistent and clear naming scheme. :-) But I guess to each their own...
Would `classloader-modules.conf`, `docs-modules.conf` and `build-modules.con` be better? Otherwise you'll need to come up with any better solutions yourself, since I'm starting to run out of ideas.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1781
More information about the build-dev
mailing list