RFR: 8199138: Add RISC-V support to Zero

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Wed Feb 12 17:08:10 UTC 2020


Hi!

On 2/12/20 5:51 PM, Aleksey Shipilev wrote:
> Neat. Looks good to me.
> 
> Minor nits in os_linux.cpp:
> 
> *) Can you move the comment to the #define line, as it is done in the similar blocks in the same file?
> 
> 1854 #ifndef EM_RISCV                          /* RISCV */
> 1855   #define EM_RISCV      243
> 1856 #endif
> 
> *) I believe this one is sorted alphabetically, so RISCV should be between __powerpc64__ and S390?
> 
> -        AARCH64, ALPHA, ARM, AMD64, IA32, IA64, M68K, MIPS, MIPSEL, PARISC, __powerpc__,
> __powerpc64__, S390, SH, __sparc
> +        AARCH64, ALPHA, ARM, AMD64, IA32, IA64, M68K, MIPS, MIPSEL, PARISC, __powerpc__,
> __powerpc64__, S390, SH, __sparc, RISCV

I have done that now. Updated RFR in [1].

Adrian

> [1] http://cr.openjdk.java.net/~glaubitz/8199138/webrev.01/

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



More information about the build-dev mailing list