jdk11 LIBZIP build and 8201349: build broken when configured with --with-zlib=bundled on gcc 7.3

[Langer, Christoph]

Hi Matthias,

yes, I suggest to backport only JDK-8201349 with setting both statements to DISABLED_WARNINGS_gcc := unused-function implicit-fallthrough as was the result of the original fix for JDK-8201349.

Cheers
Christoph

From: Baesken, Matthias <matthias.baesken at sap.com>
Sent: Freitag, 21. Februar 2020 13:45
To: jdk-updates-dev at openjdk.java.net; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>
Cc: 'magnus.ihse.bursie at oracle.com' <magnus.ihse.bursie at oracle.com>; Langer, Christoph <christoph.langer at sap.com>
Subject: jdk11 LIBZIP build and 8201349: build broken when configured with --with-zlib=bundled on gcc 7.3

Hello,  we were running into  build errors  recently  when using gcc-7   and  with-zlib=bundled    in jdk11u-dev .
This combination worked nicely in jdk/jdk .

Reason is that in jdk11 we do not have :

8201349: build broken when configured with --with-zlib=bundled on gcc 7.3

https://hg.openjdk.java.net/jdk/jdk/rev/c35eac313084

which unfortunately has a predecessor

8211029: Have a common set of enabled warnings for all native libraries

https://hg.openjdk.java.net/jdk/jdk/rev/ec62d6cab037


I'd like to have   the  gcc - warning disablements for   LIBJLI  / LIBZIP ,  but taking over the large patch   8211029    to  11   looks a bit too much .

Should I just post a separate patch  for jdk11u-dev  with the gcc warning disablements  for  LIBJLI / LIBZIP :

DISABLED_WARNINGS_gcc := unused-function implicit-fallthrough, \


? This fixes our build issues and sounds reasonable and small .

Thanks, Matthias