RFR [XS]: 8248429: Add --enable-preview as VM argument when running microbenchmarks

Peter Levart peter.levart at gmail.com
Tue Jul 7 14:26:55 UTC 2020


I suggest adding --enable-preview to JMH_JVM_ARGS in general now (it 
doesn't hurt even if classes are not compiled with --enable-preview) and 
then take time to devise an effective strategy for selectively compiling 
micro benchmarks with or without --enable-preview. At least so the 
benchmarks would work out-of-the-box when run via make test.

WDYT?


Regards, Peter


On 6/30/20 10:15 PM, Claes Redestad wrote:
> On 2020-06-30 22:12, Magnus Ihse Bursie wrote:
>>>
>>> Second to that a solution in the build would be preferable - if we can
>>> come up with something that has infinitesimal impact to build times.
>> Are we talking about many files? Could you consider listing those 
>> files explicitly in the makefile? That would make it cheap to filter 
>> them out from the normal compilation, and instead do a secondary 
>> compilation with them.
>
> Right now there's one micro using --enable-preview, so that'd be a very
> short list.
>
> /Claes



More information about the build-dev mailing list