RFR: 8256048: Incomplete gitignore setting for netbeans project [v2]
Jie Fu
jiefu at openjdk.java.net
Mon Nov 9 15:27:58 UTC 2020
On Mon, 9 Nov 2020 13:53:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Don't remove nbproject/private/
>
> .gitignore line 5:
>
>> 3: /.idea/
>> 4: /.vscode/
>> 5: /nbproject/
>
> I believe the existing nbproject/private/ is meant to catch any private files created by someone opening any of the various nbproject directories that exist in the source base, so it should probably stay. Adding an ignore for any top level nbproject directory in addition to that should be ok.
Thanks @erikj79 for your review.
Updated.
Any comments?
Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1122
More information about the build-dev
mailing list