RFR: 8256048: Incomplete gitignore setting for netbeans project [v2]

[Erik Joelsson]

On Mon, 9 Nov 2020 15:25:28 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> .gitignore line 5:
>> 
>>> 3: /.idea/
>>> 4: /.vscode/
>>> 5: /nbproject/
>> 
>> I believe the existing nbproject/private/ is meant to catch any private files created by someone opening any of the various nbproject directories that exist in the source base, so it should probably stay. Adding an ignore for any top level nbproject directory in addition to that should be ok.
>
> Thanks @erikj79 for your review.
> Updated.
> 
> Any comments?
> Thanks.

You misunderstand me. Adding the following line is fine and will make git ignore any nbproject dir in the root of the repository, which is what I assume you want:


But removing the following existing line is not, as this matches any potential private part of already existing nbproject directories:
nbproject/private/

-------------

PR: https://git.openjdk.java.net/jdk/pull/1122