RFR: 8256414: add optimized build to submit workflow

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Nov 17 09:37:31 UTC 2020


Hi Igor,

There is a long-standing bug with the intent to remove optimized builds 
(https://bugs.openjdk.java.net/browse/JDK-8183287). Given that it does 
not seem that popular, I wonder if it really is necessary to burden the 
submit workflow (and tier1 testing, as requested in 
https://bugs.openjdk.java.net/browse/JDK-8256430) with this.

At the very least, I'd like to get some input from more Hotspot 
developers to hear if they think it is a worthy cause to spend our 
resources at.

Otherwise, I believe a better way forward is to follow through on 
JDK-8183287, viz. to split up optimized builds into the two extra 
components it actually provides: enable diagnostic code in normal 
release builds (https://bugs.openjdk.java.net/browse/JDK-8183288) and 
enable tracing with INCLUDE_PRINT 
(https://bugs.openjdk.java.net/browse/JDK-8202283).

/Magnus

On 2020-11-16 19:33, Igor Ignatyev wrote:
> Hi all,
>
> Could you please review this small and trivial patch which adds `linux-x64-optimized` build to submit workflow so breakages of this build flavor would be easier to spot?
>
> Thanks,
> -- Igor
>
> -------------
>
> Commit messages:
>   - add linux-x64-optimized build
>
> Changes: https://git.openjdk.java.net/jdk/pull/1233/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1233&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8256414
>    Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/1233.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/1233/head:pull/1233
>
> PR: https://git.openjdk.java.net/jdk/pull/1233




More information about the build-dev mailing list