RFR: 8256414: add optimized build to submit workflow

[Magnus Ihse Bursie]

I see now that this PR was already integrated.

I think that any change to the submit workflow (if they add additional 
testing, and not just fix bugs) is a non-trivial change which needs 
careful consideration.

We have already had a huge influx of additional build platforms in a 
very short time. Each additional platform is subject to any kind of 
build issues, not all of which might be related to the actual patch, and 
we therefore need to weight the benefits of getting additional testing 
of build platforms to the risks that this might cause unnecessary road 
blocks for developers.

Also, I believe it is good practice when changing build code to make 
sure that at least one reviewer is a member of the Build Group 
(https://openjdk.java.net/census#build). This is not something Skara can 
enforce, so it is dependent on the good will of committers (who should 
notify the correct set of reviewers), and of JDK Reviewers to specify if 
they believe additional reviewers from any particular area is needed.

/Magnus

On 2020-11-17 10:37, Magnus Ihse Bursie wrote:
> Hi Igor,
>
> There is a long-standing bug with the intent to remove optimized 
> builds (https://bugs.openjdk.java.net/browse/JDK-8183287). Given that 
> it does not seem that popular, I wonder if it really is necessary to 
> burden the submit workflow (and tier1 testing, as requested in 
> https://bugs.openjdk.java.net/browse/JDK-8256430) with this.
>
> At the very least, I'd like to get some input from more Hotspot 
> developers to hear if they think it is a worthy cause to spend our 
> resources at.
>
> Otherwise, I believe a better way forward is to follow through on 
> JDK-8183287, viz. to split up optimized builds into the two extra 
> components it actually provides: enable diagnostic code in normal 
> release builds (https://bugs.openjdk.java.net/browse/JDK-8183288) and 
> enable tracing with INCLUDE_PRINT 
> (https://bugs.openjdk.java.net/browse/JDK-8202283).
>
> /Magnus
>
> On 2020-11-16 19:33, Igor Ignatyev wrote:
>> Hi all,
>>
>> Could you please review this small and trivial patch which adds 
>> `linux-x64-optimized` build to submit workflow so breakages of this 
>> build flavor would be easier to spot?
>>
>> Thanks,
>> -- Igor
>>
>> -------------
>>
>> Commit messages:
>>   - add linux-x64-optimized build
>>
>> Changes: https://git.openjdk.java.net/jdk/pull/1233/files
>>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1233&range=00
>>    Issue: https://bugs.openjdk.java.net/browse/JDK-8256414
>>    Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
>>    Patch: https://git.openjdk.java.net/jdk/pull/1233.diff
>>    Fetch: git fetch https://git.openjdk.java.net/jdk 
>> pull/1233/head:pull/1233
>>
>> PR: https://git.openjdk.java.net/jdk/pull/1233
>