RFR: 8256414: add optimized build to submit workflow

[Vladimir Ivanov]

> There is a long-standing bug with the intent to remove optimized builds 
> (https://bugs.openjdk.java.net/browse/JDK-8183287). Given that it does 
> not seem that popular, I wonder if it really is necessary to burden the 
> submit workflow (and tier1 testing, as requested in 
> https://bugs.openjdk.java.net/browse/JDK-8256430) with this.
> 
> At the very least, I'd like to get some input from more Hotspot 
> developers to hear if they think it is a worthy cause to spend our 
> resources at.
> 
> Otherwise, I believe a better way forward is to follow through on 
> JDK-8183287, viz. to split up optimized builds into the two extra 
> components it actually provides: enable diagnostic code in normal 
> release builds (https://bugs.openjdk.java.net/browse/JDK-8183288) and 
> enable tracing with INCLUDE_PRINT 
> (https://bugs.openjdk.java.net/browse/JDK-8202283).

I find !PRODUCT vs ASSERT distinction confusing, but irrespective of the 
way the relevant code is guarded (!PRODUCT or INCLUDE_PRINT), it has to 
be built regularly to avoid the rot. So, once the bugs you mentioned are 
addressed, optimized build can be replaced with release build + tracing 
configuration.

Regarding the most appropriate tier to put it, I don't think it has to 
be part of tier1. IMO later tiers are fine as well. But having it in 
tier1 doesn't look like a significant waste of resources.

I don't think there's a notion of tiers in submit workflow, so I'm 
strongly in favor of having optimized configuration built there.

Best regards,
Vladimir Ivanov

> On 2020-11-16 19:33, Igor Ignatyev wrote:
>> Hi all,
>>
>> Could you please review this small and trivial patch which adds 
>> `linux-x64-optimized` build to submit workflow so breakages of this 
>> build flavor would be easier to spot?
>>
>> Thanks,
>> -- Igor
>>
>> -------------
>>
>> Commit messages:
>>   - add linux-x64-optimized build
>>
>> Changes: https://git.openjdk.java.net/jdk/pull/1233/files
>>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1233&range=00
>>    Issue: https://bugs.openjdk.java.net/browse/JDK-8256414
>>    Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
>>    Patch: https://git.openjdk.java.net/jdk/pull/1233.diff
>>    Fetch: git fetch https://git.openjdk.java.net/jdk 
>> pull/1233/head:pull/1233
>>
>> PR: https://git.openjdk.java.net/jdk/pull/1233
>