RFR: JDK-8256810: Incremental rebuild broken on Macosx

Mon Nov 23 11:52:00 UTC 2020

On Sat, 21 Nov 2020 00:12:30 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> After fixing JDK-8256751, I noticed that the fix-deps-file macro isn't actually doing the right thing at all. It seems clang on Macosx is inconsistent with outputting relative or absolute paths in the deps files, so some files end up with double WORKSPACE_ROOT in the paths. It's also not handling the trailing slash after WORKSPACE_ROOT correctly, so some files are missing the slash between WORKSPACE_ROOT and the original relative path.
> 
> This time I have checked the output carefully.

Regexps really are write-only code. But I think it looks good. :-)

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1360