Integrated: JDK-8256810: Incremental rebuild broken on Macosx
Erik Joelsson
erikj at openjdk.java.net
Mon Nov 30 17:43:57 UTC 2020
On Sat, 21 Nov 2020 00:12:30 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> After fixing JDK-8256751, I noticed that the fix-deps-file macro isn't actually doing the right thing at all. It seems clang on Macosx is inconsistent with outputting relative or absolute paths in the deps files, so some files end up with double WORKSPACE_ROOT in the paths. It's also not handling the trailing slash after WORKSPACE_ROOT correctly, so some files are missing the slash between WORKSPACE_ROOT and the original relative path.
>
> This time I have checked the output carefully.
This pull request has now been integrated.
Changeset: 4c86e46d
Author: Erik Joelsson <erikj at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/4c86e46d
Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod
8256810: Incremental rebuild broken on Macosx
Reviewed-by: mikael, ihse
-------------
PR: https://git.openjdk.java.net/jdk/pull/1360
More information about the build-dev
mailing list