RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]
    Jorn Vernee 
    jvernee at openjdk.java.net
       
    Fri Oct 16 10:57:12 UTC 2020
    
    
  
On Thu, 15 Oct 2020 22:44:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/foreign_globals_x86.hpp line 32:
> 
>> 30: #define __ _masm->
>> 31:
>> 32: struct VectorRegister {
> 
> Why are these structs and not classes?
The fields are meant to be accessed directly, so I went with `struct` since the members default to public.
-------------
PR: https://git.openjdk.java.net/jdk/pull/634
    
    
More information about the build-dev
mailing list