RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v4]

Jorn Vernee jvernee at openjdk.java.net
Fri Oct 16 11:01:14 UTC 2020


On Thu, 15 Oct 2020 22:52:14 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Re-add file erroneously deleted (detected as rename)
>
> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line 3885:
> 
>> 3883:
>> 3884:   __ flush();
>> 3885: }
> 
> I think as a future RFE we should refactor this function and generate_native_wrapper since they're similar (this is
> nicer to read).  If I can remove is_critical_native code they will be more similar.

Yes, I've had similar thoughts as well. This is meant to be temporary code any ways.

-------------

PR: https://git.openjdk.java.net/jdk/pull/634



More information about the build-dev mailing list