RFR: 8253424: Add support for running pre-submit testing using GitHub Actions
Robin Westberg
rwestberg at openjdk.java.net
Wed Sep 23 13:49:50 UTC 2020
On Tue, 22 Sep 2020 14:05:42 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Sure, should not be that hard to parse something similar. The GitHub actions will probably need it in JSON format at
>> some point, but nothing a little `sed -e '1i {' -e 's/#.*//g' -e 's/"//g' -e 's/(.*)=(.*)/"\1": "\2",/g' -e
>> '$s/,\s{0,}$/}/'` won't solve. Any suggestion for the location and name of such a file? I'm thinking it would contain
>> entries like this: BOOT_JDK_VERSION="14.0.2" JTREG_VERSION="jtreg5.1-b01"
>> GTEST_VERSION="release-1.8.1"
>> LINUX_X64_BOOT_JDK_FILENAME="openjdk-14.0.2_linux-x64_bin.tar.gz"
>> LINUX_X64_BOOT_JDK_URL="https://download.java.net/java/GA/jdk14.0.2/205943a0976c4ed48cb16f1043c5c647/12/GPL/openjdk-14.0.2_linux-x64_bin.tar.gz"
>> LINUX_X64_BOOT_JDK_SHA256="91310200f072045dc6cef2c8c23e7e6387b37c46e9de49623ce0fa461a24623d"
>
> The other primary consumer of this is make/conf/jib-profiles.js. The make/conf dir would make sense to me.
>
> The challenge here is creating a set of variables that are suitable enough for both config files to consume. For
> BootJDK, we never bothered with bumping the version for updates, and I very much doubt we will do that in the future
> for github actions, so a plain major version 14, and soon 15, would be preferred from my point of view. This is however
> not enough for jib-profiles.js (yet) so we can't really share bootjdk config for now anyway. For jtreg, we specify 5.1
> and b01 as two separate metadata values. For gtest we specify the version as 1.8.1.
I added `make/conf/test-dependencies` with version numbers specified on the format that `jib-profiles.js` would expect.
Actually using them from that file as well could perhaps be a separate task though. :)
-------------
PR: https://git.openjdk.java.net/jdk/pull/284
More information about the build-dev
mailing list