RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

Erik Joelsson erikj at openjdk.java.net
Wed Sep 23 17:27:09 UTC 2020


On Wed, 23 Sep 2020 13:46:50 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> The other primary consumer of this is make/conf/jib-profiles.js. The make/conf dir would make sense to me.
>> 
>> The challenge here is creating a set of variables that are suitable enough for both config files to consume. For
>> BootJDK, we never bothered with bumping the version for updates, and I very much doubt we will do that in the future
>> for github actions, so a plain major version 14, and soon 15, would be preferred from my point of view. This is however
>> not enough for jib-profiles.js (yet) so we can't really share bootjdk config for now anyway. For jtreg, we specify 5.1
>> and b01 as two separate metadata values. For gtest we specify the version as 1.8.1.
>
> I added `make/conf/test-dependencies` with version numbers specified on the format that `jib-profiles.js` would expect.
> Actually using them from that file as well could perhaps be a separate task though. :)

The version-numbers file (which is also a shared properties style file) is not using quotes for values, which is fine
as long as there are no spaces. I believe if you read it as a properties file, you need to strip the quotes if you have
them. I prefer if version-numbers and test-dependencies using the same format.

Otherwise this looks good to me!

-------------

PR: https://git.openjdk.java.net/jdk/pull/284



More information about the build-dev mailing list