RFR: 8253424: Add support for running pre-submit testing using GitHub Actions

Robin Westberg rwestberg at openjdk.java.net
Wed Sep 23 17:58:22 UTC 2020


On Wed, 23 Sep 2020 17:24:39 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> I added `make/conf/test-dependencies` with version numbers specified on the format that `jib-profiles.js` would expect.
>> Actually using them from that file as well could perhaps be a separate task though. :)
>
> The version-numbers file (which is also a shared properties style file) is not using quotes for values, which is fine
> as long as there are no spaces. I believe if you read it as a properties file, you need to strip the quotes if you have
> them. I prefer if version-numbers and test-dependencies using the same format.  Otherwise this looks good to me!

Sounds reasonable, didn't notice that discrepancy! Fixed in the latest commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/284



More information about the build-dev mailing list