RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]
Phil Race
prr at openjdk.java.net
Tue Feb 2 22:35:41 UTC 2021
On Tue, 2 Feb 2021 21:48:36 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Look a few lines further up at my reply 3 days ago Gerard about this.
>
> I read it and not sure that it is fine to ignore this error, why not throw an exception and signal the CTextPipe_doDrawString that an error occurred like InvalidPipeException or something(Sometimes we wrap other exception like OOM into the InvalidPipeException and this seems similar case)?
> The changes look good to me, but please see my comment from my review about documenting `NormalizedPathNSStringFromJavaString()` API.
I see it. I will copy what you wrote in there.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2305
More information about the build-dev
mailing list