RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]

Phil Race prr at openjdk.java.net
Tue Feb 2 22:42:51 UTC 2021


On Tue, 2 Feb 2021 22:33:09 GMT, Phil Race <prr at openjdk.org> wrote:

>> I read it and not sure that it is fine to ignore this error, why not throw an exception and signal the CTextPipe_doDrawString that an error occurred like InvalidPipeException or something(Sometimes we wrap other exception like OOM into the InvalidPipeException and this seems similar case)?
>
>> The changes look good to me, but please see my comment from my review about documenting `NormalizedPathNSStringFromJavaString()` API.
> 
> I see it. I will copy what you wrote in there.

> I read it and not sure that it is fine to ignore this error, why not throw an exception and signal the CTextPipe_doDrawString that an error occurred like InvalidPipeException or something(Sometimes we wrap other exception like OOM into the InvalidPipeException and this seems similar case)?

OK. I will do something like throw OOME or InternalError. Since we already checked for NULL as an arg any failure here implies a deep VM problem rather than anytjhing like a 2D invalid pipe

-------------

PR: https://git.openjdk.java.net/jdk/pull/2305



More information about the build-dev mailing list