RFR: 8259288: Debug build failure with clang-10 due to -Wimplicit-int-float-conversion [v2]

Hao Sun github.com+16932759+shqking at openjdk.java.net
Tue Feb 9 05:17:06 UTC 2021


> Making the conversion explicit would fix it.
> 
> Flag '-Wimplicit-int-float-conversion' is first introduced in clang-10.
> Therefore clang-8 and clang-9 are not affected. The flag with similar
> functionality in gcc is '-Wfloat-conversion', but it is not enabled by
> '-Wall' or '-Wextra'. That's why this warning does not appear when
> building with gcc.
> 
> 
> Note that we have tested with this patch, debug build succeeded with clang-10 on Linux X86-64/AArch64 machines.
> Note that '--with-extra-cxxflags=-Wno-deprecated-copy' should be added when configuration. It's another issue (See JDK-8258010)

Hao Sun has updated the pull request incrementally with one additional commit since the last revision:

  Use static_cast<double>
  
  To match the style in this file, use static_cast to perform type
  casting.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1956/files
  - new: https://git.openjdk.java.net/jdk/pull/1956/files/99259621..5a30354c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1956&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1956&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1956.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1956/head:pull/1956

PR: https://git.openjdk.java.net/jdk/pull/1956



More information about the build-dev mailing list