RFR: 8258925: configure script failed on WSL [v4]

[David Holmes]

On Sat, 9 Jan 2021 02:02:12 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> I ran configure script on WSL 1, but it failed as below:
>> 
>> $ bash configure --enable-debug --with-boot-jdk=/mnt/d/Java/jdk-15.0.1
>> 
>>     :
>> 
>> configure: Found potential Boot JDK using configure arguments
>> configure: The command for java_to_test, which resolves as "/mnt/d/Java/jdk-15.0.1/bin/java", can not be found.
>> configure: error: Cannot locate /mnt/d/Java/jdk-15.0.1/bin/java
>> configure exiting with result code 1
>> 
>> `fixpath.sh` attempts to run `$PATHTOOL` with `.exe` if it fails with original path, but `.exe` would not be added even if `$path.exe` exists.
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Refactoring

I _think_ this is right but to be honest the multitude of variables adds to the confusion for me.

David

make/scripts/fixpath.sh line 155:

> 153:     if [[ $? -ne 0 ]]; then
> 154:       unixpath="$unixpath.exe"
> 155:       winpath="$($PATHTOOL -w "$path.exe" 2>/dev/null)"

I think it would be a little cleaner/clearer to use unixpath on line 155.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1889