RFR: 8258925: configure script failed on WSL [v4]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Sat Jan 9 13:33:57 UTC 2021


On Sat, 9 Jan 2021 09:21:20 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactoring
>
> make/scripts/fixpath.sh line 155:
> 
>> 153:     if [[ $? -ne 0 ]]; then
>> 154:       unixpath="$unixpath.exe"
>> 155:       winpath="$($PATHTOOL -w "$path.exe" 2>/dev/null)"
> 
> I think it would be a little cleaner/clearer to use unixpath on line 155.

We will check the result from `$PATHTOOL` at L154, so I think current location is fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1889



More information about the build-dev mailing list