RFR: 8260289: Unable to customize module lists after change JDK-8258411

[Magnus Ihse Bursie]

On Mon, 25 Jan 2021 13:19:31 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> make/conf/module-loader-map.conf line 100:
>> 
>>> 98: # Hook to include the corresponding custom file, if present.
>>> 99: $(eval $(call IncludeCustomExtension, conf/module-loader-map.conf)) 
>>> 100: 
>> 
>> Using IncludeCustomExtension is a good idea, but you should to this where module-loader-map.conf is included in common/Modules.gmk, not here. The `*.conf` files are supposed to be formatted as simple configuration files, and not include special make commands.
>
> @magicus Is there an ordering issue in common/Modules.gmk? It also invokes IncludeCustomExtension but this is done before it includes the conf file.

@AlanBateman I'm not sure. Frankly, most of the IncludeCustomExtension hooks are no longer used by Oracle since we've moved most of our code out in the open, so they kind of bit rot... I should probably do a sweep and ask the community which one to still keep, and remove the rest.

> @AlanBateman Yes, that's what JDK-8258411 inadvertently changed and I am fixing. I am going to now move the common/Modules.gmk IncludeCustomExtension after the module-loader-map.conf include.

Andrew, why can't you just use the existing IncludeCustomExtension then to load your own module-loader-map.conf? Or maybe that's just what you are going to do?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2219