RFR: 8260289: Unable to customize module lists after change JDK-8258411

[Andrew Leonard]

On Mon, 25 Jan 2021 13:27:29 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> @magicus Is there an ordering issue in common/Modules.gmk? It also invokes IncludeCustomExtension but this is done before it includes the conf file.
>
>> @AlanBateman Yes, that's what JDK-8258411 inadvertently changed and I am fixing. I am going to now move the common/Modules.gmk IncludeCustomExtension after the module-loader-map.conf include.
> 
> Andrew, why can't you just use the existing IncludeCustomExtension then to load your own module-loader-map.conf? Or maybe that's just what you are going to do?

The previous behavior provided the ability to "extend" the upstream MODULE lists, ie.just add OpenJ9 modules to the base module lists, see: https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/01e13c398721628540babac94ac8663be716c0a8/closed/custom/common/Modules.gmk#L21

The present https://github.com/openjdk/jdk/blob/master/make/conf/module-loader-map.conf will simply over-write whatever is set in the BOOT_MODULES list.

What I am now going to do is move the IncludeCustomExtension after the module-loader-map.conf  inclusion.
The other alternative would be to change module-loader-map.conf so it appended to any existing BOOT_MODULES variable, but I think you suggested that file is a straight conf file?

@magicus thoughts?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2219