RFR: 8285093: Introduce UTIL_ARG_WITH

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Apr 19 20:46:59 UTC 2022


Analogous to `UTIL_ARG_ENABLE`, we need a `UTIL_ARG_WITH` which wraps ´AC_ARG_WITH`, provides a declarative rather than programmatic way of handling configure arguments. It can also make sure that all edge cases are covered, and that we treat arguments consistently. 

This PR contains the implementation of `UTIL_ARG_WITH`, and an example conversation of the calls to `AC_ARG_WITH` in basic_tools.m4. There are some 120-odd more places where `AC_ARG_WITH` is called that need to be converted, but that is out of scope for this PR. Getting the m4 logic for `AC_ARG_WITH` was hard enough for this PR, and verifying a whole bunch of configure arguments is mind-numbingly boring. So I intend to attack those piecewise, fixing them in large enough batches at a time, later on.

I also fixed a bug and a documentation issue in `UTIL_ARG_ENABLE`.

-------------

Commit messages:
 - Use new default value in basic_tools.m4
 - Better default for RESULT.
 - Fix UTIL_ARG_WITH in basic_tools.m4
 - Create UTIL_ARG_WITH

Changes: https://git.openjdk.java.net/jdk/pull/8306/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8306&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8285093
  Stats: 382 lines in 2 files changed: 349 ins; 5 del; 28 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8306.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8306/head:pull/8306

PR: https://git.openjdk.java.net/jdk/pull/8306



More information about the build-dev mailing list