RFR: 8285093: Introduce UTIL_ARG_WITH
Erik Joelsson
erikj at openjdk.java.net
Wed Apr 20 13:04:45 UTC 2022
On Tue, 19 Apr 2022 20:38:31 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> Analogous to `UTIL_ARG_ENABLE`, we need a `UTIL_ARG_WITH` which wraps ´AC_ARG_WITH`, provides a declarative rather than programmatic way of handling configure arguments. It can also make sure that all edge cases are covered, and that we treat arguments consistently.
>
> This PR contains the implementation of `UTIL_ARG_WITH`, and an example conversation of the calls to `AC_ARG_WITH` in basic_tools.m4. There are some 120-odd more places where `AC_ARG_WITH` is called that need to be converted, but that is out of scope for this PR. Getting the m4 logic for `AC_ARG_WITH` was hard enough for this PR, and verifying a whole bunch of configure arguments is mind-numbingly boring. So I intend to attack those piecewise, fixing them in large enough batches at a time, later on.
>
> I also fixed a bug and a documentation issue in `UTIL_ARG_ENABLE`.
Marked as reviewed by erikj (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/8306
More information about the build-dev
mailing list