RFR: 8284949: riscv: Add Zero support for the 32-bit RISC-V architecture [v2]
Feilong Jiang
fjiang at openjdk.java.net
Wed Apr 20 02:03:39 UTC 2022
On Tue, 19 Apr 2022 11:22:37 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> LGTM
>
> Cheers, Thomas
>
> P.S. I assume you did not run the whole gamut of jtreg tests, right? Seems to me there are a number of tests which would need to get adapted for riscv32.
Thanks for the review, Thomas. Currently, we only test jtreg tier1 tests under test/hotspot and test/jdk. I assume it would be enough for adding riscv32 zero support? There are some tests adaptions to be done for riscv32 like [1] [2]. I guess it might be better to fix them in another PR.
[1] https://github.com/openjdk/jdk/blob/72726c41829b33fd2baf5b3604cab49d39489dd2/test/lib/jdk/test/lib/Platform.java#L200-L202
[2] https://github.com/openjdk/jdk/blob/72726c41829b33fd2baf5b3604cab49d39489dd2/test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java#L46-L49
-------------
PR: https://git.openjdk.java.net/jdk/pull/8284
More information about the build-dev
mailing list