RFR: 8294549: configure script should detect unsupported path [v2]

[Mike Duigou]

On Mon, 7 Nov 2022 12:27:03 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Mike Duigou has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   8294549: configure script should detect unsupported path
>>   
>>   The OpenJDK build system does not support building when the source code
>>   resides on a path that contains a space. This requirement is documented in the
>>   build instructions but not enforced by the configure script.
>>   
>>   This change adds an explicit checks to the wrapper `configure` script that fail
>>   the build if the source code to be built is located in a directory who's path
>>   contains a space character or the build path cannot be determined.
>
> configure line 34:
> 
>> 32: 
>> 33: if [ -z "${this_script_dir}" ]; then
>> 34: 	echo "# Could not determine location of configure script"
> 
> Why the initial `#`?

Just habit. Some style guides for shell commands suggest putting a "#" before error output.

-------------

PR: https://git.openjdk.org/jdk/pull/10477