RFR: 8294549: configure script should detect unsupported path [v2]
Mike Duigou
mduigou at openjdk.org
Sat Dec 3 22:11:37 UTC 2022
On Mon, 7 Nov 2022 00:28:13 GMT, Mike Duigou <mduigou at openjdk.org> wrote:
>> The OpenJDK build system does not support building when the source code resides on a path that contains a space. This requirement is documented in the build instructions but not enforced by the configure script.
>>
>> This change adds an explicit checks to the wrapper `configure` script that fail the build if the source code to be built is located in a directory who's path contains a space character or the build path cannot be determined.
>>
>> Includes some idiom modernization and shell scripting best practices changes.
>
> Mike Duigou has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
> 8294549: configure script should detect unsupported path
>
> The OpenJDK build system does not support building when the source code
> resides on a path that contains a space. This requirement is documented in the
> build instructions but not enforced by the configure script.
>
> This change adds an explicit checks to the wrapper `configure` script that fail
> the build if the source code to be built is located in a directory who's path
> contains a space character or the build path cannot be determined.
I had gotten stuck at how to regenerate the configure script but based on your suggested edit it appears the configure script is not a generated configure. I will take a look a tomorrow and either accept your suggestion or propose an alternative.
My apologies for the delays.
-------------
PR: https://git.openjdk.org/jdk/pull/10477
More information about the build-dev
mailing list