RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v7]

Magnus Ihse Bursie ihse at openjdk.org
Tue Dec 6 10:18:15 UTC 2022


On Tue, 6 Dec 2022 09:05:39 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available when both 8282948 and 8282700 were written. They can now be moved to using the cleaner logic that UTIL_ARG_WITH grants.
>> 
>> There are many more options that still use AC_ARG_WITH in jdk-version.m4. They are out of the scope of this commit, which aims only to rework the previous integrated commits mentioned above.
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Change
>  - Merge remote-tracking branch 'upstream/master' into util
>  - Include the broken options for now
>  - Uh oh
>  - branding.conf should use the DEFAULT_ prefix
>  - Use DEFAULT_DESC
>  - Merge remote-tracking branch 'upstream/master' into util
>  - Squash

make/conf/branding.conf line 27:

> 25: 
> 26: LAUNCHER_NAME=openjdk
> 27: PRODUCT_NAME=OpenJDK

This mix of `NNNN` and `DEFAULT_NNNN` looks a bit strange. Is it so that the one's that are not prefixed with `DEFAULT_` cannot be overridden by configure flags?

-------------

PR: https://git.openjdk.org/jdk/pull/11020



More information about the build-dev mailing list