RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v15]

[Magnus Ihse Bursie]

On Fri, 9 Dec 2022 18:47:29 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available when both 8282948 and 8282700 were written. They can now be moved to using the cleaner logic that UTIL_ARG_WITH grants.
>> 
>> There are many more options that still use AC_ARG_WITH in jdk-version.m4. They are out of the scope of this commit, which aims only to rework the previous integrated commits mentioned above.
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   UTIL_CHECK_STRING_NON_EMPTY_PRINTABLE

Is this on the GHA tests? Maybe the user name setting (that is, the $USER) in the github Windows hosts is strange. GHA issues are hopeless to debug. :-( I can only recommend printf-debugging, adding logging to see what is actually happening, what the user name evaluates to etc, and check every stage of the sed (or if it was tr?) expression that tries to remove invalid characters from the user name.

If all else fails, you can probably append a `--with-user-name=duke` at the configure line for GHA runs.

-------------

PR: https://git.openjdk.org/jdk/pull/11020