RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v20]

Martin Doerr mdoerr at openjdk.java.net
Fri Feb 4 16:20:12 UTC 2022


On Fri, 4 Feb 2022 16:05:02 GMT, Tyler Steele <duke at openjdk.java.net> wrote:

> I like the idea of adding the IBM copyright line more judiciously, and only when the changes I've made are significant. ProblemList.txt, where I've made a single line change, stands out in my mind as an example of where this line could be removed.

Right. Please remove it where you didn't make significant contributions. Simple changes or even removals don't justify IBMs Copyright on the whole file. I don't think this is acceptable.

> I don't believe there are any files which contain the Oracle "2022, 2022" copyright header anymore. Did you see any I'm missing @TheRealMDoerr?

Seems like you fixed them already.

> Regarding testing: I have been regularly building and testing on my AIX 7.1 dev machine. In addition, I have run tier1 tests when the changes I'm making are complete. The only tier1 failures I observe are also failing on the master branch. I'm happy for a second tester if either of you feel it's warranted, but I don't feel it is a necessity.

That sounds good. There are not many people working on AIX. You may be alone. But, I'm glad you're doing it!

> I'll sit tight for a response from Iris before proceeding.

Be warned: This may take time. You certainly want your change to get integrated at some point of time.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6885



More information about the build-dev mailing list