RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v8]

[Tyler Steele]

On Tue, 18 Jan 2022 15:23:42 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge branch 'master' into JDK-8203290
>>  - Clean up & testing
>>    
>>    - Run JFR tests in test/jdk/jdk/jfr
>>    - Fix issues found from above test suite
>>    - Remove unecessary jtreg & gtest tests
>>    - Remove ineffective `qpic=large`
>>    - TODO: jdk/jfr/event/runtime/TestNativeLibrariesEvent.java
>>  - Merge branch 'JDK-8203290' of github.com:backwaterred/jdk into JDK-8203290
>>  - 8203290: Implements Java Flight Recorder on AIX
>>    
>>     - changes build system to allow jfr feature on aix
>>     - implements NetworkPerformance, CPUPerformance, and SystemProcess
>>     interfaces from os_perf.hpp
>>     - implements jfr sanity tests
>>  - 8203290: Implements Java Flight Recorder on AIX
>>    
>>     - changes build system to allow jfr feature on aix
>>     - implements NetworkPerformance, CPUPerformance, and SystemProcess
>>     interfaces from os_perf.hpp
>>     - implements jfr sanity tests
>
> make/autoconf/flags-cflags.m4 line 421:
> 
>> 419:       # so for debug we build with '-qpic=large -bbigtoc'.
>> 420:       DEBUG_CFLAGS_JVM="-qpic=large"
>> 421:     fi
> 
> Why this removal? Note that getting the TOC not to explode on AIX has been an ongoing struggle, see this string of associated JBS issues: 
> 
> https://bugs.openjdk.java.net/browse/JDK-8184344
> https://bugs.openjdk.java.net/browse/JDK-8171408
> https://bugs.openjdk.java.net/browse/JDK-8196488
> https://bugs.openjdk.java.net/browse/JDK-8204935

Hmm, that is strange. I initially thought my code had caused the TOC overflow, and added  -qpic=large to address this. After realizing that my code was not solely responsible, I (tried) to back out of my changes without removing anything I had not added myself. It seems I should review the changes to this file one more time to ensure that I didn't get a bit carried away with the removal process. Good catch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6885