RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v7]

Tyler Steele duke at openjdk.java.net
Fri Jan 21 17:29:46 UTC 2022


On Wed, 19 Jan 2022 16:07:36 GMT, Tyler Steele <duke at openjdk.java.net> wrote:

>> make/autoconf/flags-cflags.m4 line 421:
>> 
>>> 419:     DEBUG_SYMBOLS_CFLAGS_JDK="$CFLAGS_DEBUG_SYMBOLS"
>>> 420:   fi
>>> 421: 
>> 
>> Why this removal? Note that getting the TOC not to explode on AIX has been an ongoing struggle, see this string of associated JBS issues: 
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8184344
>> https://bugs.openjdk.java.net/browse/JDK-8171408
>> https://bugs.openjdk.java.net/browse/JDK-8196488
>> https://bugs.openjdk.java.net/browse/JDK-8204935
>
> Hmm, that is strange. I initially thought my code had caused the TOC overflow, and added  -qpic=large to address this. After realizing that my code was not solely responsible, I (tried) to back out of my changes without removing anything I had not added myself. It seems I should review the changes to this file one more time to ensure that I didn't get a bit carried away with the removal process. Good catch.

I checked out the version of this file from upstream/master. All the changes I needed to make were in jvm-features.m4.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6885



More information about the build-dev mailing list