[EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs
David Holmes
david.holmes at oracle.com
Tue Jul 12 13:02:49 UTC 2022
On 12/07/2022 7:35 pm, George Adams wrote:
> Hu Alan,
>
> By using the setup-java action with release set to a major version (e.g
> 18) it will always pull the latest GA build of OpenJDK for that version.
> E.g 18 currently sets up jdk-18.0.1+10 in the GitHub actions
> environment. The point is that by switching to using a setup-java action
> it would be one fewer task to complete after each GA tag is released.
But we don't update the boot JDK when there are new update releases.
Unless there is a reason to change, the boot JDK for 19 will be 18.0.0
GA, and we only bump that number once per release cycle.
David
> -George
>
> *From: *Alan Bateman <Alan.Bateman at oracle.com>
> *Date: *Tuesday, 12 July 2022 at 10:30
> *To: *George Adams <George.Adams at microsoft.com>, build-dev at openjdk.org
> <build-dev at openjdk.org>
> *Subject: *Re: [EXTERNAL] Re: GitHub workflows using setup-java action
> instead of hardcoded URLs
>
> On 12/07/2022 10:23, George Adams wrote:
>
> H David,
>
> The key difference is that we wouldn’t nee to keep updating the full
> version number/checksum. We could ofcourse use the
> oracle-actions/setup-java
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foracle-actions%2Fsetup-java&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cf096e37ac54c4d7c4ecd08da63e92a2c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637932150365490360%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nLLnIsWQy1umcQcYoC%2BD8baKabLXu7ZQVeJH0U3ujQE%3D&reserved=0>
> and do something like this:
>
> - name: 'Set up latest Oracle JDK 18'
>
> uses: oracle-actions/setup-java at v1
>
> with:
>
> website: oracle.com
>
> release: 18
>
> I’m more than happy to leave the codebase as it is but I don’t like
> the way that we have to keep updating the version number/checksum.
>
> Bumping the version of the boot JDK is something that happens during
> every release, usually soon after the GA of the previous release. I
> don't think you can avoid that.
>
> -Alan
>
More information about the build-dev
mailing list